-
-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CDK #4167
base: master
Are you sure you want to change the base?
Add CDK #4167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR, but a change will be required.
optdepends=() | ||
options=(!strip) | ||
source=( | ||
'https://github.com/cdk-team/CDK/releases/download/v1.5.3/cdk_darwin_amd64' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't distribute pre-built binaries, we build from source.
Use this PKGBUILD template: https://github.com/BlackArch/blackarch-pkgbuilds/blob/master/PKGBUILD-go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Under any other situation, I would definitely agree with you. However, I took https://github.com/BlackArch/blackarch/blob/ab15c1a1607ff7a6f245f55be1033eceef86d52b/packages/peass/PKGBUILD as a template, and it does also seem to download pre-built binaries. In cases such as these where these binaries are not meant to be run on the host machine but distributed, it does seem to make more sense to use pre-distributed and trusted binaries, and not have to download cross-compile toolchains and packers for every architecture out there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you can read in the command for peass, it's because it was impossible to do so: sh2bin is not available for linpeas build (so it's a temporary measure intil we package sh2bin), and that winpeas build requires visual studio which is not available on linux so we have no choice. In your case it's different as it's a go binary, cross-compilation is way easier, there is no issue with gox dependency and upx is available as an official package.
Hi y'all! CDK is a zero dependency container penetration toolkit that I would really like to see added to BlackArch.