JNG-5858 transform relation components

[noherczeg]

JNG-5858 Transform relation visual elements

[coderabbitai]

Walkthrough

The recent changes significantly enhance the functionality and usability of the Judo UI framework. Key updates include improved reference handling in the TransferRelationDeclaration class, new methods for retrieving modifiers in the Modifiable class, and expanded transformation rules for both ViewLinkDeclaration and ViewTableDeclaration. Additionally, descriptive field labels have been added to test files for better clarity, and the project version in pom.xml has been updated to reflect these enhancements.

Changes

Files	Change Summary
.../transferRelationDeclaration.eol	Removed getDetail() method, replaced self.eContainer with self.getTransferContainer(), and added getTransferObjectType().
.../modifiable.eol	Introduced getWidth() and getDetail() methods, both marked as cached for efficiency.
.../viewLinkDeclaration.etl, .../viewTableDeclaration.etl	Added new rules like AbstractViewLinkDeclaration, InlineViewLink, and various table-related rules for UI transformations.
.../JslModel2UiApplicationTest.java, .../JslModel2UiDataTest.java	Added field labels to improve readability in UserRow, ProductRow, and data test rows.
.../JslModel2UiWidgetsTest.java	New testRelationWidgets() method added to validate relation widget functionality.
pom.xml	Updated version to 1.1.0.20240725_085552_28a1c2a8_feature_JNG_5858_support_new_relations.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant TransferRelationDeclaration
    participant Modifiable

    User->>UI: Request Data
    UI->>TransferRelationDeclaration: getTransferObjectType()
    TransferRelationDeclaration->>TransferRelationDeclaration: getTransferContainer()
    TransferRelationDeclaration-->>UI: Return Data
    UI->>Modifiable: getWidth()
    Modifiable-->>UI: Return Width
    UI-->>User: Display Data

Loading

🐰 Hopping through the code so bright,
New rules and labels, what a delight!
With every change, the UI shines,
Clarity blooms, like sweet grapevines. 🎉
So let’s leap forth on this sunny day,
Celebrate the updates, hip-hip-hooray!

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 95eb8b5 and 332b012.

Files selected for processing (2)

• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewLinkDeclaration.etl (1 hunks)
• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewTableDeclaration.etl (1 hunks)

Files skipped from review as they are similar to previous changes (2)

• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewLinkDeclaration.etl
• judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewTableDeclaration.etl

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

Outside diff range, codebase verification and nitpick comments (3)

judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewTableDeclaration.etl (3)

252-263: Ensure completeness of TODO items and proper handling of button group properties.

The rule InlineViewTableRowButtonGroup sets properties for the button group. However, the TODO item for adding buttons is still present and needs to be completed.

• File: judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewTableDeclaration.etl
• Lines: 252-263

Analysis chain

Ensure completeness of TODO items and proper handling of button group properties.

The rule InlineViewTableRowButtonGroup sets properties for the button group. It looks good overall, but ensure that the TODO item for adding buttons is completed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the completeness of TODO items and proper handling of button group properties in the rule `InlineViewTableRowButtonGroup`.

# Test: Search for the rule definition and usage. Expect: Completed TODO items and correct handling of button group properties.
rg --type etl -A 10 $'rule InlineViewTableRowButtonGroup'

Length of output: 86

---

Script:

#!/bin/bash
# Description: Locate the file containing the rule `InlineViewTableRowButtonGroup` and verify the completeness of TODO items and proper handling of button group properties.

# Step 1: Locate the file containing the rule definition
file_path=$(fd 'viewTableDeclaration.etl')

# Step 2: Search for the rule definition and usage within the located file
if [[ -n "$file_path" ]]; then
  rg -A 10 'rule InlineViewTableRowButtonGroup' "$file_path"
else
  echo "File not found"
fi

Length of output: 772

---

239-250: Ensure completeness of TODO items and proper handling of button group properties.

The rule InlineViewTableButtonGroup sets properties for the button group. However, the TODO item for adding buttons is still present and needs to be completed.

• File: judo-tatami-jsl-jsl2ui/src/main/epsilon/transformations/ui/modules/view/viewTableDeclaration.etl
• Lines: 239-250

Please ensure that the TODO item for adding buttons is addressed to complete the functionality of the rule.

Analysis chain

Ensure completeness of TODO items and proper handling of button group properties.

The rule InlineViewTableButtonGroup sets properties for the button group. It looks good overall, but ensure that the TODO item for adding buttons is completed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the completeness of TODO items and proper handling of button group properties in the rule `InlineViewTableButtonGroup`.

# Test: Search for the rule definition and usage. Expect: Completed TODO items and correct handling of button group properties.
rg --type etl -A 10 $'rule InlineViewTableButtonGroup'

Length of output: 83

---

Script:

#!/bin/bash
# Description: Verify the completeness of TODO items and proper handling of button group properties in the rule `InlineViewTableButtonGroup`.

# Test 1: Search for the rule definition and usage. Expect: Completed TODO items and correct handling of button group properties.
rg -A 10 $'rule InlineViewTableButtonGroup'

# Test 2: Search for TODO items in the codebase to ensure completeness.
rg 'TODO'

Length of output: 3356

---

95-128: Ensure proper handling of column properties and uncomment the relevant sections.

The rule TablePrimitiveColumn sets properties for the column. The properties customImplementation, sort, sortPrecedence, and formatValue are referenced multiple times in the codebase, indicating their importance. To maintain consistency and functionality, consider uncommenting the sections related to these properties.

• Uncomment the sections for customImplementation, sort, sortPrecedence, and formatValue in the TablePrimitiveColumn rule.

Analysis chain

Ensure proper handling of column properties and consider removing commented-out sections.

The rule TablePrimitiveColumn sets properties for the column. It looks good overall, but consider the following:

1. Ensure that the column properties are correctly retrieved and handled.
2. Consider removing or uncommenting the sections for custom implementation and sorting if they are needed.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the proper handling of column properties and consider removing commented-out sections in the rule `TablePrimitiveColumn`.

# Test: Search for the rule definition and usage. Expect: Correct handling of column properties and decision on commented-out sections.
rg --type etl -A 10 $'rule TablePrimitiveColumn'

Length of output: 77

---

Script:

#!/bin/bash
# Description: Verify the proper handling of column properties and consider removing commented-out sections in the rule `TablePrimitiveColumn`.

# Test: Search for the rule definition and usage. Expect: Correct handling of column properties and decision on commented-out sections.
rg -A 20 'rule TablePrimitiveColumn'

Length of output: 5719

---

Script:

#!/bin/bash
# Description: Search for the usage of properties related to custom implementation and sorting to determine if they should be uncommented or removed.

# Test: Search for the usage of `customImplementation` in the codebase.
rg 'customImplementation'

# Test: Search for the usage of `sort` in the codebase.
rg 'sort'

# Test: Search for the usage of `sortPrecedence` in the codebase.
rg 'sortPrecedence'

# Test: Search for the usage of `formatValue` in the codebase.
rg 'formatValue'

Length of output: 3871