Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gatling launcher script logic update fix for windows #1848

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

schneidh
Copy link

@schneidh schneidh commented Jun 26, 2024

Fix for the gatling launcher script update logic for windows. It currently does not update the launcher script correctly for the set CLASSPATH= case. (It looks like the unix logic was copied and not updated)


Each PR must conform to Developer's Guide.

Quick checklist:

  • Description of PR explains the context of change
  • Unit tests cover the change, no broken tests
  • No static analysis warnings (Codacy etc.)
  • Documentation update ('available in the unstable snapshot' warning if necessary)
  • Changes file inside site/dat/docs/changes directory, one-line note of change inside

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.86%. Comparing base (09be9b6) to head (391c4ee).
Report is 2 commits behind head on master.

Files Patch % Lines
bzt/modules/gatling.py 90.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1848      +/-   ##
==========================================
+ Coverage   89.80%   89.86%   +0.07%     
==========================================
  Files          71       71              
  Lines       19538    19544       +6     
==========================================
+ Hits        17544    17562      +18     
+ Misses       1994     1982      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant