Skip to content

Commit

Permalink
Public-Auto-release: v2.17.1
Browse files Browse the repository at this point in the history
# Changed
* Replace c++17 with c++14 call and added test to check compatibility
* Bugfix: Builds without Python failed with missing target dependency
* Enforce protobuf version 3
  • Loading branch information
blickfeld-lidar committed Feb 8, 2021
1 parent 764ac8d commit 83f8dc6
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ set (LIBINCLUDEDIR_TOP "${PROJECT_BINARY_DIR}/include")
# Protobuf
set(PROTOBUF_SRC_DIR "${PROJECT_SOURCE_DIR}/thirdparty/protobuf")
if(BF_USE_SYSTEM_PROTOBUF)
find_package(Protobuf REQUIRED)
find_package(Protobuf 3.0.0 REQUIRED)

# Check version of protobuf
if(PROTOBUF_FOUND AND Protobuf_PROTOC_EXECUTABLE)
Expand Down
7 changes: 7 additions & 0 deletions doc/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,13 @@ influence the resulting point cloud.

### Removed

## [2.17.1] - 2021.02.08

### Changed
* Replace c++17 with c++14 call and added test to check compatibility
* Bugfix: Builds without Python failed with missing target dependency
* Enforce protobuf version 3

## [2.17.0] - 2021.02.05

### Added
Expand Down
2 changes: 1 addition & 1 deletion protocol/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,8 @@ foreach(FILE ${PROTOBUF_SOURCES})
DEPENDS ${FILE}
WORKING_DIRECTORY ${PROJECT_BINARY_DIR}
)
list(APPEND PROTOBUF_GENERATED_PY ${PROTOBUF_GENERATED_PY_DIR}/${FILE_PY})
endif()
list(APPEND PROTOBUF_GENERATED_PY ${PROTOBUF_GENERATED_PY_DIR}/${FILE_PY})
endforeach()

# NPM Build (moved out of the loop as pbjs and pbts accepts all .proto files at once.)
Expand Down
5 changes: 3 additions & 2 deletions src/mockup_session.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ void mockup_session::do_read() {
}

void mockup_session::do_send() {
auto weak_self(weak_from_this());
auto self(shared_from_this());
auto weak_self = std::weak_ptr<mockup_session>(self);

send_thread = std::make_shared<asio::thread>([this, weak_self] {
while (auto self = weak_self.lock()) {
Expand Down Expand Up @@ -114,4 +115,4 @@ void mockup_session::do_send() {

} // namespace blickfeld

#endif
#endif

0 comments on commit 83f8dc6

Please sign in to comment.