-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Hammad Ghazi
committed
Oct 10, 2023
1 parent
88f6cab
commit f64c44d
Showing
2 changed files
with
40 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// SPDX-License-Identifier: MIT | ||
pragma solidity 0.8.21; | ||
|
||
error ArraysLengthMismatch(uint256 ordersArrLen, uint256 clearingPricesArrLen); | ||
error ZeroFacilitatorTargetAddress(); | ||
error EmptyOrdersArray(); |
f64c44d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too long function params variable names. make it short and explain it int the netspec for clarity
f64c44d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use Conventional Commits specification for our commit messages. This standard makes our commit history more readable and allows for automated changelog generation. By doing so, we can maintain a well-structured log of changes, making version tracking and upgrades more transparent for all users.
More about Conventional Commits: https://www.conventionalcommits.org/