Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing merge into refactored #7

Open
wants to merge 123 commits into
base: refactored
Choose a base branch
from
Open

Testing merge into refactored #7

wants to merge 123 commits into from

Conversation

HareemSaad
Copy link
Contributor

No description provided.

gul-hameed and others added 30 commits October 13, 2023 14:40
@gul-hameed
Create solhint.yml
8149f08
@gul-hameed
Create .solhint.json
22cf237
@gul-hameed
Update solhint.yml
1d1aa5a
@gul-hameed
Update solhint.yml
668dbe8
@gul-hameed
Create slither.yml
90135a8
@gul-hameed
Create test.t.sol
1fdd5ca
@gul-hameed
Create foundry-test.yml
d05f849
@gul-hameed
Update slither.yml
817de06
@gul-hameed
Update slither.yml
f9974c0
@0xabdullah0
Update slither.yml
c5b1471
@0xabdullah0
Update slither.yml
dcd1eb5
@0xabdullah0
Update slither.yml
b55ccbe
@gul-hameed
Update slither.yml
07cde01
@gul-hameed
Update solhint.yml
d717453
@gul-hameed
Update foundry-test.yml
93336cc
@gul-hameed
Update slither.yml
56c276b
@gul-hameed
Update slither.yml
3699288
@gul-hameed
Update slither.yml
019b319
@gul-hameed
Update slither.yml
da3e81a
@gul-hameed
Update slither.yml
8ddb6cb
@gul-hameed
Update slither.yml
8528bf7
@gul-hameed
Update slither.yml
9544af4
@gul-hameed
Update slither.yml
20a82a0
@gul-hameed
Create slither-output.txt
0199209
@gul-hameed
Update slither.yml
3ee2f0c
@actions-user
Update Slither analysis output
a1d0e5a
@HareemSaad
tests + Index out of bounds fix
968bac4
@HareemSaad
predicate address and fee collector tests
b95ced4
@HareemSaad
fill order happypath
26bd259
@HareemSaad
manual pull
3a3af8b
@0xabdullah0
Added Invariants
e63767a 
Added the Identified Invariants. Wrote these in plain English first.
@gul-hameed
Copy link
Contributor

@HareemSaad
can you create a unit test on this property "the contract should handle unexpected input like large arrays without failing or causing excessive gas costs" with 250-300 orders.

HareemSaad and others added 28 commits December 7, 2023 13:17
@HareemSaad
stress test
e68149c
@HareemSaad
comment fix
cf0e82d
@HareemSaad
removed status check in updateTokenWhitelist
de5df3f
@HareemSaad
qouter interface
f02f8a1
@HareemSaad
facilitator swap usingexact input
4938480
@HareemSaad
fix
5ceee3f
@HareemSaad
fee fix
75e88b7
@HareemSaad
new pegasus deploy
dca82ce
@HareemSaad
deploy on sepolia
6686cdc
@HareemSaad
OrderFill event update
951d56e
@HareemSaad
new deploy
440a4a9
@HareemSaad
select fork
efa8b6a
@HareemSaad
Breaking Change - Precicison Loss: executedAmounts to be sent in (upt…
2290b4d 
…o) 1e36, scale down for processing
@HareemSaad
new deploy
ca4fec6
@HareemSaad
fix
3d1dbf6
@HareemSaad
rem file
c222e9e
@HareemSaad
rem file
804c9ff
@gul-hameed
Update slither.yml
6f5f83b
@HareemSaad
helper functions
46b9f23
@HareemSaad
update test command
666942b
@HareemSaad
Merge branch 'development' into testing
30027d6
@HareemSaad
shift token type from IERC20 to address for type hashing compatibilit…
ffb7ef2 
…y in ethers.js
@HareemSaad
update deploy script
fbc8dfb
@HareemSaad
new deploy
96d70ed
@HareemSaad
pheonix deploy
8700faf
@HareemSaad
Minimum fee threshhold
dd7991d
@HareemSaad
Max fee cap
9a9f020
@HareemSaad
facilatator mainnet deploy
969c917
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gul-hameed gul-hameed gul-hameed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HareemSaad @gul-hameed @0xabdullah0 @actions-user