Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement add, difference, multiplication and division functions #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Idrhas
Copy link

@Idrhas Idrhas commented Apr 28, 2024

feat: implement add, difference, multiplication and division functions

feat: implement add, difference, multiplication and division functions
@Idrhas Idrhas changed the title Update lib.cairo feat: implement add, difference, multiplication and division functions Apr 28, 2024
Copy link
Contributor

@sprtd sprtd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice attempt @Idrhas
However, there are compilation errors; always ensure your code compiles successfully whenever you run scarb build or scarb cairo-run
Fix the errors and re-request review

@Idrhas
Copy link
Author

Idrhas commented Apr 29, 2024

it's compiling now sir, kindly review sir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants