-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add context handling with accept/reject #61
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
- Coverage 97.76% 97.73% -0.04%
==========================================
Files 39 39
Lines 2197 2211 +14
Branches 381 385 +4
==========================================
+ Hits 2148 2161 +13
Misses 30 30
- Partials 19 20 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@adrien-berchet , when you have 5min, if you can take a look at this to see if the general implementation makes sense. I will then use context to modify the prob() function. |
Looks nice! |
4c626ea
to
81bc3e6
Compare
dc4b7ec
to
7dfe6dd
Compare
@lidakanari @adrien-berchet , this can be reviewed as well, again, it is experimental, so not fully tested |
8d5e4fe
to
937600b
Compare
937600b
to
58c4f44
Compare
233625e
to
e129ef1
Compare
e129ef1
to
79ac8c4
Compare
29a57c3
to
301455f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 97.86% 97.88% +0.01%
==========================================
Files 39 39
Lines 2200 2217 +17
Branches 382 296 -86
==========================================
+ Hits 2153 2170 +17
Misses 29 29
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Co-authored-by: Adrien Berchet <[email protected]>
Co-authored-by: Adrien Berchet <[email protected]>
Co-authored-by: Adrien Berchet <[email protected]>
Co-authored-by: Adrien Berchet <[email protected]>
4e746da
to
9baf834
Compare
This PR adds an accept/reject mechanisms to allow for external modification of section and trunk growths via the generic
context
object.