Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function/covmatrix #20

Merged
merged 21 commits into from
Jul 23, 2024
Merged

Function/covmatrix #20

merged 21 commits into from
Jul 23, 2024

Conversation

schickjo
Copy link
Collaborator

@schickjo schickjo commented Jul 5, 2024

Please also check tests once again

Schick and others added 14 commits April 30, 2024 17:01
…teriorOutput()) to enable use of full covariance matrix for posteriors

- added if-condition to getPosterior() to differenciate between se_matrix and se_vector input

- added new attribute to getPosteriorI() to also include full covariance matrices in output
- added new tests to test-posterior.R for new functions in posterior.R (full covariance matrix)
…d input parameters

- updated postmix2RBesT() to implement more efficient coding methods

- extracted ESS calculation steps into its own function calcESS() in order to avoid redundant code
…List() in setup.R

- added more and better fitting unit tests for postmix2RBesT() to cover updates to the function
- priorList2priorMix(): migrated mapping code to separate function createMapping()

- getPosteriorOutput(): completely revamped getPosteriorOutput() to now use already available mapping sheets from priorList2priorMix() for the creation of the posterior list -> also renamed to postMix2posteriorList()
- added two new tests and updated other tests to account for new syntax in postMix2posteriorList()
…dx() and createMapping() within the function postMix2posteriorList()

- tidied and restructured code
…Posterior()

- updated how the covariance matrices are collected within getPosteriorI() and postMix2posteriorList()

- createMapping() is now its own function to allow use in both getPosteriorI() and postMix2posteriorList() for mapping of covariance matrices
…ues not zero

- added new tests to test-posterior.R to cover scenarios with a matrix without zeros

- added new tests to test-posterior.R for equal results for a scenario with se_hat input as vector and S_hat input as matrix

- created new function test_covmatrix_symmetry() in test-posterior.R to avoid redundant code
@schickjo schickjo requested a review from Xyarz July 5, 2024 09:20
Schick and others added 7 commits July 8, 2024 09:15
- changed input variable of getPosterior() in analyis_normal_noninformative vignette from se_hat to S_hat
Merge branch 'main' of https://github.com/Boehringer-Ingelheim/BayesianMCPMod into function/covmatrix

# Conflicts:
#	vignettes/analysis_normal_noninformative.qmd
@Xyarz Xyarz merged commit 8f196db into main Jul 23, 2024
6 checks passed
@Xyarz Xyarz deleted the function/covmatrix branch July 23, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants