-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function/covmatrix #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teriorOutput()) to enable use of full covariance matrix for posteriors - added if-condition to getPosterior() to differenciate between se_matrix and se_vector input - added new attribute to getPosteriorI() to also include full covariance matrices in output
- added new tests to test-posterior.R for new functions in posterior.R (full covariance matrix)
…d input parameters - updated postmix2RBesT() to implement more efficient coding methods - extracted ESS calculation steps into its own function calcESS() in order to avoid redundant code
…List() in setup.R - added more and better fitting unit tests for postmix2RBesT() to cover updates to the function
- priorList2priorMix(): migrated mapping code to separate function createMapping() - getPosteriorOutput(): completely revamped getPosteriorOutput() to now use already available mapping sheets from priorList2priorMix() for the creation of the posterior list -> also renamed to postMix2posteriorList()
- added two new tests and updated other tests to account for new syntax in postMix2posteriorList()
…dx() and createMapping() within the function postMix2posteriorList() - tidied and restructured code
…Posterior() - updated how the covariance matrices are collected within getPosteriorI() and postMix2posteriorList() - createMapping() is now its own function to allow use in both getPosteriorI() and postMix2posteriorList() for mapping of covariance matrices
…ues not zero - added new tests to test-posterior.R to cover scenarios with a matrix without zeros - added new tests to test-posterior.R for equal results for a scenario with se_hat input as vector and S_hat input as matrix - created new function test_covmatrix_symmetry() in test-posterior.R to avoid redundant code
- changed input variable of getPosterior() in analyis_normal_noninformative vignette from se_hat to S_hat
Merge branch 'main' of https://github.com/Boehringer-Ingelheim/BayesianMCPMod into function/covmatrix # Conflicts: # vignettes/analysis_normal_noninformative.qmd
…T package - renamed prior_list in setup.R
…ect of RBesT package
…onas as ctb and adjustign docu
Xyarz
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please also check tests once again