Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added quiet feature to read_params #14

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

tschwarzl
Copy link
Contributor

Added a quiet feature to read_params to suppress messages and warnings from reading with dso get-config

@tschwarzl tschwarzl requested review from DSchreyer and grst October 17, 2024 06:42
@grst
Copy link
Collaborator

grst commented Oct 17, 2024

I'm wondering if this should be made consistent with the CLI:

  • also add verbose flag
  • quiet can take an integer for different "levels" of quiet:
--quiet    -q  INTEGER RANGE  Reduce verbosity. -q disables info messages, -qq disables warnings. Errors messages cannot be disabled. The same can be achieved by setting the env var DSO_QUIET=1 or DSO_QUIET=2, respectively.                                                                                                                                       
--verbose  -v                 Increase logging verbosity to include debug messages. The same can be achieved by setting the env var DSO_VERBOSE=1. 

Also note that it would be possible to set --quiet in dso -qq exec quarto . or globally using

dso:
  quarto:
     before_script: "export DSO_QUIET=2"

and it would be quiet only when executing from the command line, but not when running interactively.

R/read_params.R Outdated Show resolved Hide resolved
Co-authored-by: Gregor Sturm <[email protected]>
@tschwarzl
Copy link
Contributor Author

and it would be quiet only when executing from the command line, but not when running interactively.

@grst we can definitly discuss this. at the moment the verbose mode introduces bugs in the notebook display of Rstudio server.

@DSchreyer
Copy link
Collaborator

I tested and the quiet function works as expected.

@grst
Copy link
Collaborator

grst commented Oct 21, 2024

at the moment the verbose mode introduces bugs in the notebook display of Rstudio server.

What sort of?
Maybe it would be better to fix the output on the python side than reverting to quiet by default.

But feel free to merge, I don't mind having this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants