-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rc/1.1.0 #12
Open
iglauss
wants to merge
33
commits into
main
Choose a base branch
from
rc/1.1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rc/1.1.0 #12
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
374342a
Formalize interface with papo.
ml-ebs-ext 94f97bf
Isolate common portions of papo interface test.
ml-ebs-ext 4e25d25
Remove duplicates.
ml-ebs-ext 79bf4a3
Simplify papo test harness.
ml-ebs-ext f13c571
Tweaks suggested by PR.
ml-ebs-ext d4a40a2
Merge pull request #8 from Boehringer-Ingelheim/formal_papo_iface
ml-ebs-ext 677823f
multiple drugs per patient - POC
iglauss 8b2fcea
Display multiple drugs per subject POC
mattkorb e06dd00
Fix start/equal symbols and shape legend
iglauss 06985b4
Add size to geom_point
mattkorb a25619e
add color_palette argument
iglauss d35a9b7
Refine color_palette checks
iglauss 885360b
Update mod call to enable users to specify trt_var
iglauss 59482e6
fix unit tests
iglauss d9ce092
Add tests for customizable colors
iglauss def9193
Add test for check_valid_color() function
iglauss 8a409ff
Fix tooltip
mattkorb f2af6a5
update switch2 to switch2mod
iglauss a6a192e
update mock apps
iglauss 7719e81
Update NEWS file.
iglauss c19fe28
fix legend label issue when drug_admin = NULL; fix error when only ti…
iglauss 69e79eb
tests: update snapshot and get rid of warnings
iglauss d3a8511
solve commented_code_linter findings
iglauss 88b7696
update documentation
iglauss 1dbb39c
update DESCRIPTION file to contain latest dv.manager version
iglauss 26f42da
fix failing tests
iglauss 75cec1a
failing tests: increase wait_for_idle() timeout time
iglauss 1f3a7d6
update large test app to fix failing test
iglauss 249f8b8
update papo jumping test
iglauss dfbd199
Merge pull request #11 from Boehringer-Ingelheim/multiple-drugs-handling
iglauss b24df9a
update version number
iglauss 4e2161f
Merge branch 'main' into rc/1.1.0
iglauss 1b0cad7
add mock_with_mm_app to _pkgdown.yml
iglauss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
Package: dv.clinlines | ||
Title: DaVinci's Clinical Timelines | ||
Version: 1.0.4 | ||
Version: 1.1.0 | ||
Authors@R: | ||
c( | ||
person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")), | ||
|
@@ -21,7 +21,7 @@ Imports: | |
bslib (>= 0.6.1), | ||
checkmate (>= 2.3.1), | ||
dplyr (>= 1.1.0), | ||
dv.manager (>= 2.1.0), | ||
dv.manager (>= 2.1.4), | ||
ggplot2 (>= 3.4.4), | ||
lubridate (>= 1.9.3), | ||
magrittr (>= 2.0.3), | ||
|
@@ -46,7 +46,6 @@ Suggests: | |
testthat (>= 3.2.1) | ||
Config/testthat/edition: 3 | ||
Roxygen: list(markdown = TRUE) | ||
RoxygenNote: 7.3.1 | ||
Remotes: boehringer-ingelheim/[email protected].2 | ||
RoxygenNote: 7.3.2 | ||
Remotes: boehringer-ingelheim/[email protected].4 | ||
VignetteBuilder: knitr | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use the label argument of drug admin instead of hard coding Durg Administration :)