Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc/4.0.0 #7

Merged
merged 13 commits into from
Jun 21, 2024
Merged

Rc/4.0.0 #7

merged 13 commits into from
Jun 21, 2024

Conversation

mattkorb
Copy link
Contributor

Critical checks

  • Is the version number correct?
  • Does the build pass?

Template

  • Is the template correctly used?
  • If modified is it commented accordingly?

Documentation

Does it include the following sections?

  • Module introduction with features
    • (O) Screenshots
  • Installation details
  • Explanation of function arguments
  • Explanation of input menus
  • Data specifications and requirements
  • Different possible visualizations
    • (O) Screenshots
  • (O) Short articles on building the app, compatibility with other modules, known bugs,...
  • Are the new features included in NEWS.md?

QC Report

  • Does it include a QC Report?

API conventions

  • Follows API convention

@mattkorb mattkorb requested a review from zsigmas June 21, 2024 10:17
@mattkorb mattkorb requested a review from a team as a code owner June 21, 2024 10:17
@mattkorb mattkorb merged commit 9b72518 into main Jun 21, 2024
8 checks passed
@mattkorb mattkorb deleted the rc/4.0.0 branch June 21, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zsigmas zsigmas zsigmas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattkorb @zsigmas