Skip to content

Commit

Permalink
Merge pull request #35 from Boehringer-Ingelheim/rc/v2.1.4
Browse files Browse the repository at this point in the history
Rc/v2.1.4
  • Loading branch information
ml-ebs-ext authored Nov 26, 2024
2 parents 78823e5 + 14e9b3c commit e8d0a2f
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 15 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: dv.manager
Type: Package
Title: DaVinci Module Manager
Version: 2.1.3
Version: 2.1.4
Authors@R: c(person("Boehringer-Ingelheim Pharma GmbH & Co.KG", role = c("cph", "fnd")),
person('Sorin', 'Voicu', email = '[email protected]', role = c('aut')),
person('Luis', 'Morís Fernández', email = '[email protected]', role = c('cre', 'aut')))
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# dv.manager 2.1.4

- Removes leftover title automatic capitalization.

- Extends Arguments From Module Manager to include include a `data` slot that acts as a pass-through of the `run_app` argument by the same name.

# dv.manager 2.1.3

- dv.manager includes the option to filter using several datasets
Expand Down
1 change: 1 addition & 0 deletions R/app_server.R
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ app_server_ <- function(input, output, session, opts) {
}

module_args <- list(
data = data,
unfiltered_dataset = unfiltered_dataset,
filtered_dataset = filtered_dataset,
url_parameters = url_parameters,
Expand Down
1 change: 0 additions & 1 deletion inst/www/css/custom.scss
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ body {
li {
a {
padding: 16px 20px;
text-transform: capitalize;
color: $color-text;
background-color: $primary;
color: $color-text;
Expand Down
23 changes: 10 additions & 13 deletions vignettes/arguments_from_module_manager.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ knitr::opts_chunk$set(
)
```

```{r setup}
```{r setup, include = FALSE}
library(dv.manager)
```



When developing a module we create a wrapper function that returns a list that is used to instantiate a given module
When developing a module, we create a wrapper function that returns a list that is used to instantiate a given module
inside module manager. Within this list the `server` is a function with a single parameter provided by module manager when
the server function is called. This parameter by convention usually called `afmm`, an acronym of **a**rguments **f**rom **m**odule **manager**. `afmm` is a list with the following entries:
the server function is called. This parameter by convention usually called `afmm`, an acronym of **a**rguments **f**rom **m**odule **m**anager. `afmm` is a list with the following entries:

1. **data**: a list of lists of data frames (or of functions that return data frames). Pass-through of the `run_app` argument by the same name.

1. **unfiltered_dataset**: a metaReactive list containing the tables inside the selected dataset before filtering them.

Expand All @@ -32,11 +32,9 @@ the server function is called. This parameter by convention usually called `afmm

1. **dataset_name**: a reactive string containing the name of the selected dataset. (Deprecated)

1. **dataset_metadata**: a list with following entries:

1. **name**: a reactive string with the name of the selected dataset

1. **date_range**: a reactive character vector with two entries earliest and latest modification date in the dataset.
1. **dataset_metadata**: a list with the following entries:
a. **name**: a reactive string with the name of the selected dataset
a. **date_range**: a reactive character vector with two entries earliest and latest modification date in the dataset.

1. **module_output**: a function that when called returns a list of all the values returned by the different modules indexed by the module_id.

Expand Down Expand Up @@ -93,7 +91,6 @@ mod_table <- function(table_name, mod_id) {
mod
}
data_list <- list(
"D1" = list(adsl = pharmaverseadam::adsl, adae = pharmaverseadam::adae),
"D2" = list(adsl = pharmaverseadam::adsl, adae = pharmaverseadam::adae)
Expand All @@ -113,7 +110,8 @@ run_app(
```

When creating the module list we can select which of the tables inside the dataset we will access. Nonetheless, this is
just a design choice of the module developer. See below another possible example in which we can also select
just a design choice of the module developer. See below another possible example in which we can select either the
filtered or unfiltered dataset input by toggling the logical `filtered` parameter.

```{r, eval = FALSE}
mod_table <- function(table_name, filtered = FALSE, mod_id) {
Expand All @@ -132,7 +130,6 @@ mod_table <- function(table_name, filtered = FALSE, mod_id) {
mod
}
data_list <- list("D1" = list(adsl = pharmaverseadam::adsl, adae = pharmaverseadam::adae))
module_list <- list(
Expand Down

0 comments on commit e8d0a2f

Please sign in to comment.