Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] rc/v0.0.2hotfix #8

Closed
wants to merge 3 commits into from
Closed

[release] rc/v0.0.2hotfix #8

wants to merge 3 commits into from

Conversation

zsigmas
Copy link
Contributor

@zsigmas zsigmas commented Nov 22, 2024

Critical checks

  • Is the version number correct?

  • Does the build pass?


Documentation

Does it include the following sections?

  • Module introduction with features

    • (O) Screenshots
  • Installation details

  • Explanation of function arguments

  • Data specifications and requirements

  • Different possible visualizations

  • Are the changes/new features included in NEWS.md?

  • (O) Screenshots

  • (O) Explanation of input menus

  • (O) Short articles on building the app, compatibility with other modules, known bugs,...


QC Report

  • Does it include a QC Report?

API conventions

  • Follows API convention

@zsigmas zsigmas requested a review from a team as a code owner November 22, 2024 11:56
gm-ebs-ext
gm-ebs-ext previously approved these changes Nov 22, 2024
receiver_id = NULL,
server_wrapper_func = identity) {
receiver_id = NULL
# ,server_wrapper_func = identity # nolint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change prevents mock_app_hierarchical_count_table_mm() from working.

@ml-ebs-ext
Copy link
Contributor

@zsigmas, FYI:
The early_error_feedback branch builds on this one and adds basic support for early error feedback, communication of datasets used to dv.manager and a basic Dressing Room interface. It also removes dispatchers and triggers GH actions on all branches.

I'm in no hurry to merge it, but I just thought I mentioned it in case we decide it makes sense to bundle all new changes for v0.0.2.

@zsigmas zsigmas closed this Dec 3, 2024
@ml-ebs-ext ml-ebs-ext deleted the rc/v0.0.2 branch December 3, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants