Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object Cache Drop In Feature Enable Check #1005

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

jacobd91
Copy link
Contributor

@jacobd91 jacobd91 commented Dec 3, 2024

Added check to drop in file to prevent object cache from initializing if it is disabled but the drop in remains in place (should be removed if it is in the default location).

… if it is disabled but the drop in remains in place (should be removed if it is in the default location).
@jacobd91 jacobd91 self-assigned this Dec 3, 2024
@jacobd91 jacobd91 added the bug Something isn't working label Dec 3, 2024
@jacobd91 jacobd91 added this to the 2.8.1 milestone Dec 3, 2024
@jacobd91 jacobd91 requested a review from cssjoe December 3, 2024 19:34
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.89%. Comparing base (931cccb) to head (1b015d0).

Files with missing lines Patch % Lines
wp-content/object-cache.php 0.00% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             master   #1005      +/-   ##
===========================================
- Coverage      0.89%   0.89%   -0.01%     
  Complexity    19709   19709              
===========================================
  Files           679     679              
  Lines         99832   99842      +10     
===========================================
  Hits            893     893              
- Misses        98939   98949      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cssjoe cssjoe modified the milestones: 2.8.1, 2.8.2 Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

object-cache.php does not check that the plugin is enabled / object cache is enabled
3 participants