Skip to content
This repository has been archived by the owner on Sep 2, 2020. It is now read-only.

RxJava Support #121

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

BraunreutherA
Copy link

…able() to the Task class which execute the task and converts the result to an observable
@ghost
Copy link

ghost commented May 19, 2016

By analyzing the blame information on this pull request, we identified @yunarta, @stefanrusek and @grantland to be potential reviewers.

@ghost
Copy link

ghost commented May 19, 2016

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@BraunreutherA
Copy link
Author

TODO: tests

@grantland
Copy link
Member

This adds a hard dependency to Bolts-Android, which means we cannot accept this as it'll require anything depending on Bolts-Android to also depend on RxJava, so we cannot accept this.

@yunarta
Copy link
Contributor

yunarta commented Mar 6, 2017

should not approve this. now Rx version is 2 as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants