cleaned up dependencies, typing, changed actions

.github/workflows/unit-tests.yaml

@@ -9,31 +9,25 @@ on:
 jobs:
   test:
     runs-on: ubuntu-latest
-    strategy:
-      matrix:
-        python-version: ["3.12"]
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Python
+
+      - name: Set up poetry
+        run: pipx install poetry
+
+      - name: Set up Python 3.12
         uses: actions/setup-python@v5
         with:
-          python-version: ${{ matrix.python-version}}
+          python-version: "3.12"
+
       - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          python -m pip install -r dev-requirements.txt
+        run:
+          poetry install
+
       - name: Run tests
         run: python -m pytest --cov=acc_lcsh_check/
+
       - name: Send report to Coveralls
         uses: AndreMiras/coveralls-python-action@develop
         with:
-          parallel: true
-          github-token: ${{ secrets.GITHUB_TOKEN}}
-  finish:
-    needs: test
-    runs-on: ubuntu-latest
-    steps:
-      - name: Coveralls Finished
-        uses: AndreMiras/coveralls-python-action@develop
-        with:
-          parallel-finished: true
+          github-token: ${{ secrets.GITHUB_TOKEN}}

acc_lcsh_check/checker.py

@@ -1,11 +1,11 @@
 import datetime
 import csv
 import os
-from rich import print
+from typing import Generator
 from acc_lcsh_check.lcsh import LCTerm
 
 
-def read_data(file: str):
+def read_data(file: str) -> Generator:
     with open(file, "r") as csvfile:
         reader = csv.reader(csvfile)
         for item in reader:

acc_lcsh_check/lcsh.py

@@ -3,7 +3,7 @@
 
 
 class LCTerm:
-    def __init__(self, id: str, old_heading: str, id_type: str):
+    def __init__(self, id: str, old_heading: str, id_type: str) -> None:
         self.id = id
         self.old_heading = old_heading
         self.id_type = id_type

pyproject.toml

@@ -15,7 +15,6 @@ types-requests = "^2.31.0.20240311"
 pytest = "^8.1.1"
 pytest-cov = "^5.0.0"
 pytest-mock = "^3.14.0"
-rich = "^13.7.1"
 
 [tool.pytest.ini_options]
 testpaths = ["tests"]

tests/test_checker.py

@@ -1,5 +1,6 @@
 import datetime
 import pytest
+from typing import Generator
 
 from acc_lcsh_check.checker import read_data, get_data
 
@@ -9,6 +10,7 @@ def test_read_data():
     for term in data:
         assert term[0].strip('" ') == "Foo"
         assert term[1].strip('" ') == "sh00000000"
+    assert isinstance(data, Generator)
 
 
 @pytest.mark.parametrize("heading_type", ["subjects", "names", "demographicTerms"])