-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.1.0 #119
Merged
Merged
Release v1.1.0 #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* updated dependencies and version * updated WorldcatAccessToken with scope/scopes changes * updated changelog and advanced docs added test
* added ignore flake8 F401 for test_bookops_worldcat * added types-pyyaml as dev dependency * added type annotations removed unnecessary imports * deleted test.mrc as it is now redundant * fixed typo in import statement * exported updated dev-requirements.txt * added 3.13 to unit-tests.yaml * fixed live_keys fixture for GITHUB_ACTIONS
* added bib_search method to MetadataSession class * added section on /search/bibs/ endpoint to docs * fixed return type for bib_search method
* added cascadeDelete arg to holdings_unset methods * updated docs to reflect holdings unset changes
* added yaml file for monthly live test gh action * added additional webtest for WorldcatAccessToken * updated contributing.md with info about live tests * added fixtures for live tests and monthly checks * separated live tests into two classes * renamed, simplified endpoint_params fixture * reviewing changes to MetadataSession webtests * moved webtests to separate files and directory * created separate conftest for webtests * fixed typos in conftest docstrings * separated webtests into different classes * updated monthly test schedule * added additional type annotations to conftest.py * updated live_keys fixture for posix and windows * updated triggers in monthly-api-tests.yaml * moved live_keys fixture to webtests/conftest.py * changed triggers for webtest workflow * fixed typo in conditionals * changed live_token fixture scope to reduce calls * added automatic retries to holdings tests
* updated version in __version__.py * updated changelog for version 1.1.0 * fixed date in changelog * updated release checklist and contribution guide * changed package version, added python 3.13 * updated all dependencies * added additional dependency updates to changelog * added link to detailed code changes in changelog * fixed failing test due to change in api response
klinga
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Charlotte!
Nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
bib_search
method withinMetadataSession
class allows users to retrieve full MARC records in JSON format with the new/worldcat/search/bibs/{oclcNumber}
cascadeDelete
arg added toholdings_unset
andholdings_unset_with_bib
methods. LHR and LBD records will be deleted when unsetting holdings on a record in WorldCat. This default functionality can be changed by settingcascadeDelete
toFalse
conftest.py
scope
added as a return value inWorldcatAccessToken
tests and documentationscope
as a parameter but it appears to be interchangeable withscopes
. It is listed in the tests and documentation forWorldcatAccessToken
but is not included as an attribute for the class.types-pyyaml
(6.0.12)Changed
tests/webtests
directorytests/webtests/conftest.py
certifi
(2024.8.30)charset-normalizer
(3.4.0)idna
(3.10)requests
(2.32.3)urllib3
(2.2.3)babel
(2.16.0)black
(24.8.0)coverage
(7.6.1)exceptiongroup
(1.2.2)griffe
(1.4.0)importlib-metadata
(8.5.0)importlib-resources
(6.4.5)jinja2
(3.1.4)markdown
(3.7)mike
(2.1.3)mkdocs-autorefs
(1.2.0)mkdocs-get-deps
(0.2.0)mkdocs-material
(9.5.44)mkdocs
(1.6.1)mkdocstrings-python
(1.10.0)mkdocstrings
(0.24.3)mypy
(1.13.0)packaging
(24.2)paginate
(0.5.7)platformdirs
(4.3.6)pluggy
(1.5.0)pygments
(2.18.0)pymdown-extensions
(10.12)pyparsing
(3.1.4)pytest-mock
(3.14.0)python-dateutil
(2.9.0.post0)pytz
(2024.2)pyyaml
(6.0.2)regex
(2024.11.6)tomli
(2.1.0)types-requests
(2.32.0.20241016)typing-extensions
(4.12.2)urllib3
(2.2.3)watchdog
(4.0.2)wheel
(0.45.0)zipp
(3.20.2)Fixed
MetadataSession
methods is nowrequests.Response
notOptional[requests.Response]
Removed
conftest.py
stub_marc21
fixture to returnbytes
and removedtest.mrc
file