Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #13(std::variant) #21

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Issue #13(std::variant) #21

wants to merge 6 commits into from

Conversation

w3rew
Copy link

@w3rew w3rew commented May 20, 2019

Also it requires compilation with -std=c++17

@w3rew w3rew changed the title Issue #13 Issue #13(std::variant) May 20, 2019
include/real/real.hpp Outdated Show resolved Hide resolved
include/real/real.hpp Outdated Show resolved Hide resolved
@sdavtaker
Copy link
Contributor

Travis run is failing. Error seems to be that variant library is not available, check the images you using are new enough to have it, or the parameters passed to the compiler are including the right STL.

Copy link
Collaborator

@Laouen Laouen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, is ok, but there are some code styles changes to do before merging.

include/real/real.hpp Outdated Show resolved Hide resolved
include/real/real.hpp Outdated Show resolved Hide resolved
include/real/real.hpp Outdated Show resolved Hide resolved
@w3rew
Copy link
Author

w3rew commented May 21, 2019

Frankly speaking I didn't manage to make travis(and cmake) use c++17

@sdavtaker
Copy link
Contributor

Hi,
Can you resubmit this PR in https://github.com/BoostGSoC19/Real and close it here?
This Repository is frozen now that repository for 2019 exist.
We do not have permissions to merge here anymore, and also it will get out of sync with the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants