-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #13(std::variant) #21
base: master
Are you sure you want to change the base?
Conversation
Travis run is failing. Error seems to be that variant library is not available, check the images you using are new enough to have it, or the parameters passed to the compiler are including the right STL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, is ok, but there are some code styles changes to do before merging.
and updated travis config to use gcc 8.
Frankly speaking I didn't manage to make travis(and cmake) use c++17 |
Hi, |
Also it requires compilation with -std=c++17