Updated modifiability on rule application

Set board modifiability of the current transition to false when a contradiction is applied in ValidateContradictionRuleCommand; Removed previous change to TreeController.
Bram-Hub · Oct 14, 2023 · 3ddb5b5 · 3ddb5b5
1 parent 9b68d11
commit 3ddb5b5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/main/java/edu/rpi/legup/controller/TreeController.java b/src/main/java/edu/rpi/legup/controller/TreeController.java
@@ -2,6 +2,7 @@
 
 import edu.rpi.legup.model.Puzzle;
 import edu.rpi.legup.model.tree.Tree;
+import edu.rpi.legup.model.tree.TreeElementType;
 import edu.rpi.legup.ui.boardview.BoardView;
 import edu.rpi.legup.ui.proofeditorui.treeview.*;
 
@@ -55,7 +56,6 @@ public void mouseReleased(MouseEvent e) {
         Puzzle puzzle = getInstance().getPuzzleModule();
         TreeViewSelection selection = treeView.getSelection();
         if (treeElementView != null) {
-            treeElementView.getTreeElement().getBoard().setModifiable(!treeElementView.getTreeElement().isContradictoryBranch());
             if (e.isShiftDown()) {
                 selection.addToSelection(treeElementView);
             }

diff --git a/src/main/java/edu/rpi/legup/history/ValidateContradictionRuleCommand.java b/src/main/java/edu/rpi/legup/history/ValidateContradictionRuleCommand.java
@@ -66,9 +66,11 @@ public void executeCommand() {
             if (transition == null) {
                 transition = tree.addNewTransition(treeNode);
                 transition.setRule(newRule);
+                transition.getBoard().setModifiable(false);
                 tree.addTreeElement(transition);
             }
             else {
+                transition.getBoard().setModifiable(false);
                 tree.addTreeElement(treeNode, transition);
             }