Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite with GitHub Actions #634

Merged
merged 20 commits into from
Oct 10, 2023

Conversation

charlestian23
Copy link
Collaborator

@charlestian23 charlestian23 commented Oct 10, 2023

Description

The test suite now runs with GitHub Actions for any pull request or commit into master or dev. The test suite is run on Ubuntu, macOS, and Windows.

As far as I can tell, this should work, since I added some dummy tests (which I have deleted now), and those tests were marked as failed. I have not tested by purposely breaking a rule and then seeing if the corresponding test breaks since our test suite is under construction currently and I'm not sure which tests are completely reliable and which are not.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@charlestian23 charlestian23 marked this pull request as ready for review October 10, 2023 19:02
Copy link
Collaborator

@Chase-Grajeda Chase-Grajeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@Chase-Grajeda Chase-Grajeda merged commit a52b65d into Bram-Hub:dev Oct 10, 2023
5 checks passed
@charlestian23 charlestian23 deleted the github-actions-test-suite branch April 16, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants