Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added FinishWithTentsTest #676

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Conversation

Kevin-771
Copy link
Collaborator

@Kevin-771 Kevin-771 commented Oct 27, 2023

Description

added tests to FinishWithTentsTest
added comments to FinishWithTentsTest

Closes #604

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Kevin-771 Kevin-771 changed the base branch from master to dev October 27, 2023 20:52
@Kevin-771 Kevin-771 marked this pull request as ready for review November 3, 2023 22:01
@charlestian23 charlestian23 requested a review from Corppet November 7, 2023 16:59
@charlestian23 charlestian23 requested a review from Bram28 November 7, 2023 16:59
Copy link
Collaborator

@Corppet Corppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Project builds just fine with the new unit tests. Comments are clear but a visual representation of the puzzle may be helpful (i.e. draw the grid and mark TENT or GRASS tiles).

Copy link
Member

@Bram28 Bram28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without a working dev I can;t really comment on this. But I see it has one positive review, so I'll go ahead and approve :P

@charlestian23
Copy link
Collaborator

Without a working dev I can;t really comment on this. But I see it has one positive review, so I'll go ahead and approve :P

Alright, I'll merge this PR then.

@charlestian23 charlestian23 merged commit 0e2d70b into Bram-Hub:dev Nov 9, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] Finish With Tents
4 participants