Finish room case rule attempt #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/cadogs/LEGUP into Surround_Completed_Region_newest
…s no case rules that alter 2 separate puzzzle tiles I added the basis for those in the case rule class
Remove unecessary changes from caseRule.java. Show all work before deleting uneccesary bits from finishRoom case rule attempt.
First clean attempt at rule.
need help
…/LEGUP into FinishRoomCaseRuleAttempt
Rooms seem to be finished correctly including all edge cases. Arrow color is still red but may be fixed when updating my branch.
Removed print statements and unnecessary lines
Green arrows now show when rule is ran correctly. Red arrow when incorrect and larger than 5 paths. Started the test case for it.
Work on test class and start of work within Rule and CaseRule to correctly display error message when too many cases are generated
Max cases is generalized for each case rule. Can be altered from the original 10 to whichever you choose. I input 5 for finish room and 2 for black or white case rule in Nurikabe but can be done for case rules in other puzzles. AutoCaseRuleCommand was changed as well to display message when too many cases of the case rule is generated.
Created and added new image to display the finish room case rule
charlestian23
requested changes
Mar 26, 2024
Initial passing cases, may need additional work but currently passes.
…/LEGUP into FinishRoomCaseRuleAttempt
This comment was marked as outdated.
This comment was marked as outdated.
…/LEGUP into FinishRoomCaseRuleAttempt
Fixes green arrow when using case rule after altering 1 random tile. Also sets minimum cases number to 2.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
charlestian23
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #(issue)
Type of change
How Has This Been Tested?
Checklist: