-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minesweeper #771
Minesweeper #771
Conversation
This reverts commit ace7122.
removed fillapix imports
Added the unset puzzle element, added the minesweeper board copy function, fixed the bomb or filled case rule
This reverts commit ace7122.
Added helper functions used for getting cells adjacent to flag, as well as combinations of possible bomb tiles.
This reverts commit b4c8ed9.
-Fixed Bomb or Filled case rule picture -Added getTileNumber and setCellType functions -added 5x5 test puzzle
This reverts commit f9d52a3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments. Other the two comments I made, the general structure of the code looks fine. I didn't look specifically into the general logic of the rules, I trust you guys to do that. I'll look over the rules more closely when the puzzle is ready to be merged into dev
.
|
||
public class Unset extends NonPlaceableElement { | ||
public Unset() { | ||
super("MINE-UNPL-0002", "Unset", "A blank tile", "edu/rpi/legup/images/fillapix/tiles/UnknownTile.png"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer if you guys made a copy of the Fillapix unknown tile and put it in the Minesweeper directory. All the other puzzles have their own unknown tile images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you guys have an empty cell tile? If not, just ignore this comment. But if you do, I'd prefer if you modified this tile to have an empty cell tile. This way, we can just have two branches in the icon and it can be the same size as all the other icons.
Description
Closes #(issue)
Type of change
How Has This Been Tested?
I used a few example minesweeper puzzle files to make sure the case rule worked in a few different scenarios (in the middle, on edges, corners, etc.)
Checklist: