-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved auto-formatter behavior #781
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing these changes on my fork now doesn't work
Changed branch name to be unique and fail task on master PRs
…an23/LEGUP into improve-auto-formatter
Attempting improvements
Automated Java code formatting changes
Automated Java code formatting changes
Automated Java code formatting changes
Chase-Grajeda
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good yaml, good for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After seeing the errors thrown by the auto-formatter in #776, I changed the auto-formatter's behavior:
dev
, the auto-formatter functions the same, though the method used for detecting formatting changes has been improved.dev
, the auto-formatter will check if there are formatting changes that are necessary. Then, if there are formatting changes, the auto-formatter will open a new pull request with those changes intodev
. This is because of branch protections, as the auto-formatter doesn't have permissions to directly push ontodev
.Note: The changes to
GridRegion.java
were made by the auto-formatter.Type of change
How Has This Been Tested?
I tested these changes in my fork by mimicking the permissions of
master
anddev
. I then created bad formatting commits both to and fromdev
to ensure that these changes work.Checklist: