Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final Marcus pull #814

Merged
merged 37 commits into from
Apr 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
8ccd118
Update ThermometerBoard.java
morenomarcus03 Feb 6, 2024
d7d2d9f
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Feb 13, 2024
3fec0d0
Created element files
morenomarcus03 Feb 13, 2024
f8ba1c7
Element/rule images
morenomarcus03 Feb 17, 2024
0e87d8c
Too many mercury 1st draft
morenomarcus03 Feb 23, 2024
0e0590d
Too few mercury contradiction rule
morenomarcus03 Feb 24, 2024
ed87892
Merge remote-tracking branch 'upstream/master' into thermometer
morenomarcus03 Feb 27, 2024
eb1024b
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Feb 27, 2024
db63375
error fixes
morenomarcus03 Feb 27, 2024
1ce4fe0
misc cleanup
morenomarcus03 Mar 12, 2024
5884fb3
Starting on case rules
morenomarcus03 Mar 15, 2024
e7bc798
Rest is Empty direct rule and getHead for vials
morenomarcus03 Mar 15, 2024
41ed022
Prior is filled rule and getTail functionality
morenomarcus03 Mar 15, 2024
f5fb27a
Prior filled small fix
morenomarcus03 Mar 15, 2024
257f801
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Mar 15, 2024
00e4f14
Retrofit because I forgot to merge for 2 weeks
morenomarcus03 Mar 15, 2024
f88fb18
Rest empty quick fix
morenomarcus03 Mar 15, 2024
a1ae841
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Mar 26, 2024
32176b5
Images with thicker lines/orientations
morenomarcus03 Mar 26, 2024
8c0be33
New more visible rule images
morenomarcus03 Mar 30, 2024
2a3553c
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Apr 2, 2024
a8cbe3d
small addition
morenomarcus03 Apr 2, 2024
cc8aa2f
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Apr 2, 2024
36648ff
Rule Stubs
morenomarcus03 Apr 3, 2024
996e453
Final rule images
morenomarcus03 Apr 4, 2024
68a162a
Major Bug Fix
morenomarcus03 Apr 5, 2024
f8ec2aa
Right Click works now
morenomarcus03 Apr 5, 2024
56f7990
Reference Sheet Fill-out
morenomarcus03 Apr 9, 2024
79e2776
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Apr 12, 2024
6d73076
Update therm_test.xml
morenomarcus03 Apr 12, 2024
000cb65
Merge branch 'Bram-Hub:thermometer' into thermometer
morenomarcus03 Apr 12, 2024
0e77a25
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Apr 12, 2024
a526b4f
Merge branch 'thermometer' of https://github.com/morenomarcus03/LEGUP…
morenomarcus03 Apr 12, 2024
350e145
final final rule image
morenomarcus03 Apr 12, 2024
967ddef
small comments
morenomarcus03 Apr 16, 2024
a1c66b0
comments
morenomarcus03 Apr 16, 2024
5bbe98c
Merge remote-tracking branch 'upstream/thermometer' into thermometer
morenomarcus03 Apr 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,13 @@ public boolean containsCell(ThermometerCell cell){
return false;
}

//basic accessors
//Returns cell containing head of thermometer
public ThermometerCell getHead(){return cells.getFirst();}

//Returns cell containing tail of thermometer
public ThermometerCell getTail(){return cells.getLast();}

//Retruns all cells in vial, from head to tip
public ArrayList<ThermometerCell> getCells(){return cells;}

//checking for discontinuous flow inside of vial
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import java.util.ArrayList;

//TODO: Rule is untested
public class DiscontinuousMercuryContradictionRule extends ContradictionRule{

private final String NO_CONTRADICTION_MESSAGE = "Does not contain a contradiction at this index";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import java.util.ArrayList;
import java.util.List;

//TODO: Rule is untested
public class MercuryOrBlockedCaseRule extends CaseRule {
public MercuryOrBlockedCaseRule() {
super("THERM-CASE-0001",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

import java.util.ArrayList;

//TODO: Rule is untested
public class PriorFilledDirectRule extends DirectRule {

public PriorFilledDirectRule() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
import java.util.ArrayList;
import java.util.Set;

//TODO: Rule is untested
public class RestEmptyDirectRule extends DirectRule {

public RestEmptyDirectRule() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import edu.rpi.legup.puzzle.thermometer.ThermometerCell;
import edu.rpi.legup.puzzle.thermometer.ThermometerFill;

//TODO: Rule is untested
public class TooFewMercuryContradiction extends ContradictionRule{

private final String Invalid_Use_Message = "Mercury can still reach limit";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import edu.rpi.legup.puzzle.thermometer.ThermometerCell;
import edu.rpi.legup.puzzle.thermometer.ThermometerFill;

//TODO: Rule is untested
public class TooManyMercuryContradiction extends ContradictionRule{

private final String Invalid_Use_Message = "Mercury does not exceed limit";
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
THERM-BASC-0001 : RestEmptyDirectRule
THERM-BASC-0002 : PriorFilledDirectRule
THERM-BASC-0003 : FinishWithMercuryDirectRule
THERM-BASC-0004 : FinishWithBlockedDirectRule
THERM-BASC-0005 : MinimumFillDirectRule
THERM-BASC-0006 : ThermometerTooLargeDirectRule

THERM-CONT-0001 : DiscontinuousMercuryContradictionRule
THERM-CONT-0002 : TooFewMercuryContradiction
THERM-CONT-0003 : TooManyMercuryContradiction

THERM-CASE-0001 : MercuryOrBlockedCaseRule
THERM-CASE-0001 : MercuryOrBlockedCaseRule
THERM-CASE-0002 : SatisfyMercuryCaseRule

Images can be found/edited here:
https://docs.google.com/presentation/d/1YHNog2fGvLJEx4kbJZiwwAlP-m2-E1O7hGh0HJ7S0gE/edit?usp=sharing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading