fix: avoid perm errors by making node_modules access unprivileged #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK thanks, I'll do some testing. |
|
I'm sorry this has been a year, but I don't think it works as intended. I've not seen permissions problems with the existing setup. Do you have a working example that I can reproduce your permissions error. Everything is installed/copied as node user in the Dockerfile, so I'm not sure what the original issue could be. In this PR, the real node_modules is moved up a directory after install, effectively making it no different than the main branch it's changing. Then this PR changes the npm install example to not install modules in the proper path. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows packages to be installed via
docker-compose exec <service> npm i <package>closes #91. See #49 for the original discussion.
May also affect #28 by removing the need for individual file mounts as mentioned in the comments there, but it needs to be tested on Docker Toolbox/hyper-v to be sure.
Something to keep in mind is that this change makes the named volume (
notusedin compose) persist the results of the command above. removing volumes when needed (docker-compose down -v), or mounting an unnamed volume since it behaves like tmpfs mounts for our purposes (:/opt/node_app/app/node_modules), solves this case.Also apologies for the late PR, life gets in the way 😄