Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MA-8]: Added appropriate ARIA attributes in the channel header #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MA-8]: Added appropriate ARIA attributes in the channel header #10

wants to merge 2 commits into from

Conversation

ayush-chauhan233
Copy link
Collaborator

@ayush-chauhan233 ayush-chauhan233 commented Dec 4, 2024 •
edited
Loading

Summary

  • Updated the channel header accordion.
  • Wrapped the accordion button inside the header
  • Added aria-expanded and aria-control attributes

Steps to reproduce

  • Navigate to the Town Square button and select it.
  • Inspect its element with Chrome DevTools.
  • Review its nesting structure.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the values for "Expanded".

Expected Behavior

  • Channel header accordion must have a header that wraps the accordion toggle button.
  • The toggle button must have aria-expanded and aria-controls attributes set.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61587

Screenshots

Before After

Release Note

NONE

@ayush-chauhan233 ayush-chauhan233 self-assigned this Dec 4, 2024
@ayush-chauhan233 ayush-chauhan233 changed the base branch from release-10.2 to master December 9, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaurabhSharma-884 SaurabhSharma-884 SaurabhSharma-884 approved these changes

@avas27JTG avas27JTG avas27JTG approved these changes

Assignees

@ayush-chauhan233 ayush-chauhan233

Labels
On External
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayush-chauhan233 @avas27JTG @SaurabhSharma-884