Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-13]: Updated the Theme list section in the settings modal #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayush-chauhan233
Copy link
Collaborator

Summary

  • Updated the premade theme and custom theme radio button accordion.
  • Replaced divs with buttons to ensure keyboard navigation for the premade themes.
  • Updated the accordion in custom theme section and added aria-expanded and aria-controls attributes.

Steps to reproduce

  • Navigate to the the Display tab control using down arrow key.
  • Now navigate to the Theme edit button and select it.
  • Now navigate to the Custom Theme radio button using arrow keys.
  • Now navigate to the Sidebar Styles button and notice that the control is not reachable by the keyboard.

Expected Behavior

  • The premade theme and custom theme radio button accordion must be keyboard accessible as well its content.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61592

Screenshots

Before After

Release Note

NONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants