[MA-30]: MM-61604: Provide proper name, role, and state information to skin tone accordion #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaurabhSharma-884
force-pushed
the
ma_30/issue_mm_61604
branch
from
c1657a6 to
d5bbf21
Compare
ayush-chauhan233
requested changes
Dec 20, 2024
webapp/channels/src/components/emoji_picker/components/emoji_picker_skin.tsx
Show resolved
Hide resolved
webapp/channels/src/components/emoji_picker/components/emoji_picker_skin.tsx
Outdated
Show resolved
Hide resolved
webapp/channels/src/components/emoji_picker/components/emoji_picker_skin.tsx
Outdated
Show resolved
Hide resolved
ayush-chauhan233
requested changes
Dec 20, 2024
| <div className={classNames('skin-tones__content', {'skin-tones__content__single': !this.state.pickerExtended})}> | ||
| {this.state.pickerExtended ? this.extended() : this.collapsed()} | ||
| <div | ||
| id='skin-tones-content' |
There was a problem hiding this comment.
Is this id still needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There are accordions without appropriate state information like Skin tone button. This PR adds appropriate role, state information to it.
Steps to reproduce
Ticket Link
Fixes: https://mattermost.atlassian.net/browse/MM-61604
Screenshots
Release Note