Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MA-32]: Added logic to correctly give accessible name to channel header button #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ayush-chauhan233
Copy link
Collaborator

Summary

  • Added aria-labelled by to system bot heading in the channel header
  • Updated the aria-label on the channel header button to announce the channel name correctly.
  • Removed aria-label from the disable calls button

Steps to reproduce

  • Locate the Town Square button control.
  • Inspect it with Chrome DevTools.
  • In the Accessibility tab, expand the Computed Properties section.
  • Review the value for "Name".
  • Notice that this value does not include the visible text of the control as a substring.
  • Review the value for "Description".

Expected Behavior

  • The screen reader must announce the accessible button name correctly.

Ticket Link

Jira https://mattermost.atlassian.net/browse/MM-61646

Screenshots

Release Note

NONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant