Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support add + remove blocks to a stack #16

Merged
merged 12 commits into from
Oct 4, 2023
Merged

Conversation

DivadNojnarg
Copy link
Collaborator

Will fix #15

@DivadNojnarg DivadNojnarg self-assigned this Sep 28, 2023
@codecov
Copy link

codecov bot commented Sep 28, 2023

The author of this PR, DivadNojnarg, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@DivadNojnarg
Copy link
Collaborator Author

Still todo:

  • Add confirm button to add block.
  • Fix missing data rendering for added block.
  • Be able to remove a block.

@DivadNojnarg
Copy link
Collaborator Author

@nbenn : I noticed that when I remove a block from a stack with only 1 block, I do get:

list()
attr(,"name")
[1] "pzbsytnpwvtgitb"
attr(,"class")
[1] "stack"

which seems consistent. Then for some reasons, the stack seems to automatically add a new block to itself.

@DivadNojnarg
Copy link
Collaborator Author

So far: we can add a new block to a stack with a data_block. We can remove that new block and repeat again. What does not work: empty the stack and add a new block: for some reasons the stack refills and this mess up the process. I also don't check when we remove a data block and there are other blocks downstream (this should raise an error in the UI saying that the data block is mandatory)...

@DivadNojnarg
Copy link
Collaborator Author

Progress:

  • Can add block to empty stack.
  • Can add block to any existing stack.
  • Can remove any block, except a data block when there are downstreams block.
  • Can remove data block when it is the only block remaining.

@nbenn TO DO: add server testing (testServer) to improve coverage.

@DivadNojnarg
Copy link
Collaborator Author

I am done with this one @nbenn and @christophsax. Feel free to check. I'll improve the look and feel with the second ongoing pull request.

@DivadNojnarg DivadNojnarg requested a review from nbenn October 2, 2023 06:38
@DivadNojnarg DivadNojnarg merged commit 614f159 into main Oct 4, 2023
5 checks passed
@DivadNojnarg DivadNojnarg deleted the 15-update-stack branch October 13, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: dynamically update a stack
1 participant