Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc #382

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Update doc #382

merged 8 commits into from
Jun 11, 2024

Conversation

DivadNojnarg
Copy link
Collaborator

@DivadNojnarg DivadNojnarg commented Jun 6, 2024 •
edited by nbenn
Loading

Fix #381, #377.

@DivadNojnarg
Copy link
Collaborator Author

@nbenn Took he freedom to move linting step to the first CICD check as this is so frustrating to fail a pipeline after 10 min just for a whitespace.
Screenshot 2024-06-06 at 22 32 50

@codecov Codecov
Copy link

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (4218ae7) to head (8a9b542).

❗ Current head 8a9b542 differs from pull request most recent head 452b7ad

Please upload reports for the commit 452b7ad to get more accurate results.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #382   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files          21       21           
  Lines        2158     2158           
=======================================
  Hits         1830     1830           
  Misses        328      328

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DivadNojnarg
Copy link
Collaborator Author

@nbenn Ready for review. I edited the news.md and the version number to 0.0.2 as the old one was 0.0.1.9000. Let me know if I missed elements in this news.md.

@DivadNojnarg DivadNojnarg marked this pull request as ready for review June 7, 2024 13:11
@DivadNojnarg DivadNojnarg requested a review from nbenn as a code owner June 7, 2024 13:11
nbenn
nbenn approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@nbenn nbenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

NEWS.md Outdated

# Old way
stack <- new_stack(
new_ data_block,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo.

NEWS.md Outdated
select_blk <- new_select_block("STUDYID")

stack <- new_stack(
data_blk,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also inline, the ctor calls.

@DivadNojnarg DivadNojnarg merged commit 39aec7b into main Jun 11, 2024
5 checks passed
@DivadNojnarg DivadNojnarg deleted the 381-update-doc branch August 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbenn nbenn nbenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update doc, pkgdown, ...
2 participants
@DivadNojnarg @nbenn