Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered block loading not disappearing #388

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Rendered block loading not disappearing #388

merged 2 commits into from
Jul 2, 2024

Conversation

JohnCoene
Copy link
Member

This a (probably temp) fix to the loading issue.

On my end the loading icon sometimes does not go away.

@DivadNojnarg it's not a super elegant solution but it's to do with the (AFAIK) new Shiny's renderAsync function, it's impossible to tell when a piece of UI is rendered.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (39aec7b) to head (d2ae237).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #388   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files          21       21           
  Lines        2158     2159    +1     
=======================================
+ Hits         1830     1831    +1     
  Misses        328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JohnCoene. Looks ok to me for now. Could you please:

  • Bump DESCRIPTION version number to 0.0.2.9000.
  • Add an entry to new.md with the corresponding change, as well as in the pkgdown yml file.
  • Remove the console.log from the shiny.js JS script.

@JohnCoene
Copy link
Member Author

Sorry about the nasty console.log it's removed

Copy link
Collaborator

@DivadNojnarg DivadNojnarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DivadNojnarg DivadNojnarg merged commit db3f076 into main Jul 2, 2024
7 checks passed
@DivadNojnarg DivadNojnarg deleted the fix.rendered branch August 23, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants