Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

389 doc update #391

Merged
merged 19 commits into from
Jul 17, 2024
Merged

389 doc update #391

merged 19 commits into from
Jul 17, 2024

Conversation

DivadNojnarg
Copy link
Collaborator

  • Add diagrams from useR2024 presentation.
  • Add field explanation in intro vignette.
  • Add brief workspace section in intro vignette.
  • Embed useR2024 slides.

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.80%. Comparing base (db3f076) to head (300244a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #391   +/-   ##
=======================================
  Coverage   84.80%   84.80%           
=======================================
  Files          21       21           
  Lines        2159     2159           
=======================================
  Hits         1831     1831           
  Misses        328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DivadNojnarg DivadNojnarg marked this pull request as ready for review July 17, 2024 09:52
@DivadNojnarg DivadNojnarg requested a review from nbenn as a code owner July 17, 2024 09:52
@DivadNojnarg
Copy link
Collaborator Author

@nbenn We're good for review here, updated the new.md as well. We now have a better github readme with more context and example, an entire vignette with various case studies, more diagrams, and info inherited from the useR2024 slides ...

Copy link
Collaborator

@nbenn nbenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@DivadNojnarg DivadNojnarg merged commit 5be1578 into main Jul 17, 2024
7 checks passed
@DivadNojnarg DivadNojnarg deleted the 389-doc-update branch August 23, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants