-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better add blocks #413
Merged
+635
−140
Merged
Better add blocks #413
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
6714780
add basic pieces
DivadNojnarg 74e9200
use accordion
DivadNojnarg 205dd03
add status messages, start registry input/output checks
DivadNojnarg 7a80cbe
add get compatible blocks + simplify logic
DivadNojnarg cacd37e
fix tests + tweaks
DivadNojnarg 6b40188
fix update issue
DivadNojnarg 3d422cc
update news
DivadNojnarg 3bae043
lint
DivadNojnarg 3aa7ca0
revert param change from stack_header.stack
DivadNojnarg 75c9899
update pkgdown ref
DivadNojnarg df43ab8
fix issue with data blocks
DivadNojnarg 11fd4bb
lint ...
DivadNojnarg 4fde991
fix issue with workspace: remove immediate
DivadNojnarg 56b0995
better handle result block availability
DivadNojnarg 9d9f720
category default to avoid breaking change
DivadNojnarg 33884eb
lint + redoc
DivadNojnarg 58a93a3
news issue
DivadNojnarg f24223e
new logic for entry point blocks
DivadNojnarg a2bffa1
refactor add block: add search/select feature
DivadNojnarg 0d2df9a
always the linter ...
DivadNojnarg ac9ae95
comestic changes (width and height of search container)
DivadNojnarg bdabf6a
review PR comments
DivadNojnarg 30c5446
doc issue
DivadNojnarg 488c781
...
DivadNojnarg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to expose a name for the constructor here? The names here are just the names used for constructor bindings in the
block_registry
environment. If aresult_block
is calledresult_block
in this environment, this is to be treated more as a coincidence than a "rule".There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's an artifact I needed for the accotdions and pills but we don't need anymore with the new virtual select. To cleanup.