Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version to 16 in gh-workflow #188

Merged

Conversation

technophile-04
Copy link
Member

Description

In favor of #187 we have to update the node version to >=16 because @formatjs/[email protected] requires it. checkout failed job

Even though we are doing :

  - run: yarn workspace backend install

It seems that yarn first does yarn install which leads to installing @formatjs/[email protected] which is being used react-app workspace.

Current approach :

Updated the node version from 14.x to 16.x and also updated the run task from :

- run: yarn workspace backend install
+ run: yarn install

Actually, there is no need of updating run task but since yarn workspace backend install runs yarn install prior updated it to only run yarn install.

Found this approach minimal and working.

Test :

Tired doing yarn install using node v16 locally and it seems everything works.

Also tried running gh-workflow using node v16 checkout details here( Although tests failed but yarn install workded)

Approches explored :

  1. yarn workspace backend install --focus : It seems that if you use --focus option it fetches from npm registry and it gives the below error : Screenshot 2023-05-07 at 9 23 56 PM checkout the OG discussion install --focus tries to install workspace dependencies from npm yarnpkg/yarn#5864 . Also I read somewhere that --focus is of no use if you haven't hosted packages on npm registry but couldn't find the reference now : (
  2. yarn install --scope @scaffold-eth/monorepo/backend : even this doesn't work : ( , it was suggested here -> install --focus should respect dependency listings and private flags yarnpkg/yarn#6715 (comment)

@netlify
Copy link

netlify bot commented May 8, 2023

‼️ Deploy request for wonderful-kirch-4ab41a rejected.

Name Link
🔨 Latest commit f0fe319

@technophile-04 technophile-04 requested a review from carletex May 8, 2023 13:33
@carletex
Copy link
Collaborator

carletex commented May 8, 2023

Thanks for this @technophile-04

Pushed a commit fixing the tests.

Note: The backend is still running on node 14. I think we won't have any issues, since it only deploys the backend package. But I'll plan on test on node16/18 and update the prod env.

@carletex carletex merged commit 2ce47da into BuidlGuidl:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants