-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom chains #129
Add custom chains #129
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Nitpick: If you add a custom chain with the same chainId of a viem chain, we showing the "delete" icon also to the viem chain. Maybe the use case doesn't even make sense, ignore if you feel like it's no worth to fix. |
I'm having problems with Heimdall in a Sepolia contract that is working fine in prod and [main] branch on local. Heimdall is working fine with other contracts (maybe it is just working in the contracts I had ABI stored in local storage?).
Also I feel maybe we should tweak the UI from this on big screens :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GJ getting all of this together Port! ❤
I'm still testing the features, but I'm feeling maybe we should have separated this in 2 PRs, one for custom chains and another for the local storage ABI (which is a great feature to have btw!!)
Maybe it was needed to do them together this time, but if it wasn't, for future PRs I think it would be better/easier to split in smaller pieces 🙌
Thanks @portdeveloper!! I was just doing basic testing and when you make transaction the UI keeps showing loading notification and never updates / refetch the Contract Readonly variables, although the transaction receipt is shown : Example image :Notice that it, it showed transaction receipt dropdown but still the Transaction notification is in loading state : To test try doing the transaction here http://localhost:300/0xE009aea21af005e6B531B5f4a8f909C64A0c596d/11155111?methods=setGreeting |
The usual route of using the home page and then clicking decompile with heimdall works when I try it: Maybe the commits I did above fixed it But your question made me realize that we should probably handle the following case as well. https://abi.ninja/0xFB30C0790128b97e3aC540E6124e512E37c47D00/11155111 when the user goes to this link s/he should have the change to decompile the contract. |
packages/nextjs/components/NetworksDropdown/AddCustomChainModal.tsx
Outdated
Show resolved
Hide resolved
packages/nextjs/components/NetworksDropdown/AddCustomChainModal.tsx
Outdated
Show resolved
Hide resolved
Thanks @portdeveloper, Looks great!! Let's wait for Pablo to test it nicely 🙌 Regarding :
I think we could do better on UI / UX in The UX flow (I think) can be improved in img 1 is similar to homepage we should give the user to decompile with Heimdall or input custom ABI For img 2 (also can be implemented in homepage add chain modal) : As soon as the user types the |
TYSM for the tweaks @portdeveloper! I think it's working nicely now and then we can focus on localstorage ABI. I found some issue with ENS resolving:
Edit: It's also not working on input fields, for example if you try to set an ens in this address field: I think after this we should be good to merge, and then we can create a separate issue to tackle #129 (comment) and whatever other small issue that may be left. |
TYSM @portdeveloper !! and @Pabl0cks for testing!! Also tested and everything seems to work 🙌 Just pushed a couple of small commits. Regarding 1fbd6a3, I think maybe in other PR we can also ask for blockexplorer(optional) link in "Add chains" input, so that Address component can href to it. Merging this 🚀🚀 |
Description
This PR:
Known issues:
_Closes #97 #128