feat: ✨ add builder page for _indralukmana_ #16
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Very nice written code and personal page @indralukmana!
Really appreciate the effort.
I don't have much to add, just a few small suggestions below.
Thanks for the excellent PR!
| import IndraSparkleName from "~~/app/builders/0x80Ad2861Ab5D4EeA61330A4bd7d6969357C463C3/_components/IndraSparkleName"; | ||
| import { Address } from "~~/components/scaffold-eth"; | ||
|
|
||
| const BuilderPage: React.FC = () => { |
There was a problem hiding this comment.
You might consider using the NextPage type here, as this component is intended to be used specifically as a page and likely won't be reused elsewhere.
There was a problem hiding this comment.
Thanks! missed that type, NextPage is the proper type here. Also remind me of on my Todo for researching linter rules related to Next.js usages.
fixed at 0acaedc (#16)
| @@ -0,0 +1,14 @@ | |||
| const IndraAboutMeSection = () => { | |||
| return ( | |||
| <section className="container mx-auto space-y-2"> | |||
There was a problem hiding this comment.
You could include a picture of yourself or an avatar to add a more personal and friendly touch.
There was a problem hiding this comment.
I actually don't have a lot of photo 😆 grabbing some recent one here. Was planning to get some user/profile NFT but haven't got a chance to look for something I'd like.
fixed at 95b455c (#16)
|
Thank you for the reviews @phipsae! sent my fixes 🎉 |
|
Very nice job! Appreciated, and merged :) |
Description
Add personal builder page for indralukmana with following points of considerations:
package.json(mostly leveraging the existing React Icons lib)Addresscomponent from ScaffoldETH for ETH address related informationThe followings are sample screenshots of the page in mobile and desktop views, displayed in dark and light mode:
💻 Desktop Views
📱 Mobile Views
Additional Information
Related Issues
Your ENS/address: 0x80Ad2861Ab5D4EeA61330A4bd7d6969357C463C3