-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main page tweak - builders github activities #29
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @MexicanAce 👏 will do the adjustments
…nd add comments for functions
@indralukmana is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
I authorized the fork deployment to Vercel - hopefully that fixes the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Indra, everything looks good to me but I got a lot of TypeScript complaints in dataFetches.ts. In getBuildersPRData and getBuildersIssueActivities the types 'pr', 'issue', 'comment', 'reaction' and 'author' all have implicit type of 'any' so TS doesn't like it. Everything compiled fine for me and the page looks excellent so if it was my repo I wouldn't worry about it but if we want to be thorough maybe add some types for these.
type PullRequest = {
author: {
login: string;
};
state: "OPEN" | "CLOSED" | "MERGED";
};
etc.
hey @RafaelCaso thank you for reviewing the PR 👏. I'm not sure if I'm getting the same issue. The types are already done in Would you mind to check these?
|
Yeah I checked those before. Like you said, the file githubQueriesTypes has the necessary types. I suspected it was just on my end. Other than that everything looks good to me, thanks for the very thorough documentation and responses |
Description
This PR implements a Proof of Concept (POC) for ideas discussed in Issue #7.
Key Features
Implementation Details
Considerations
Setup
.env
file with a GitHub access token:.env.example
file for the new entryNOTE: I included test access token in
octokit.ts
file, this might or might not work in the future as this is a limited access token for test account with expiryImprovements
These are some improvements that might be worth considering, however some of these might be out of scope for this project.
Screenshots
💻 Desktop
📱Mobile
Additional Information
Related Issues
#7
Your ENS/address: 0x80Ad2861Ab5D4EeA61330A4bd7d6969357C463C3
Other
GitHub GraphQL explorer https://docs.github.com/en/graphql/overview/explorer