Issue 2: Adding personal page #21
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
|
||
| const ProfilePage: NextPage = () => { | ||
| return ( | ||
| <> |
There was a problem hiding this comment.
I think you can remove this empty fragment since you already have a one wrapping parent div
| <div className="flex flex-col gap-y-6 lg:gap-y-8 py-8 lg:py-12 justify-center items-center"> | ||
| <div | ||
| className="bg-base-100 border-base-300 border shadow-md shadow-secondary rounded-3xl px-6 lg:px-8 mb-6 space-y-1 py-4" | ||
| style={{ width: "80%" }} |
There was a problem hiding this comment.
Nit: Actually already there is tailwind class present for 80% w-4/5. And also sometimes if tailwind doesn't provide the class for that value out of box you can use the bracket syntax to use any arbitary value eg: w-[84%].
here are the docs for arbitary values.
There was a problem hiding this comment.
Hey thanks @guidoPeirano! Looking great and minimal! Just added a couple of small comments could you please update it? Thanks!!!
|
Oh no! @danitome24 linked to |
|
Merged! |
Description
In this PR:
Additional Information
Related Issues
_Closes #9
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address:0xcefb233406133224AE9b19444d836F6a33593F13