Issue #2 - abdulkadir personal page #35
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Thanks for your personal page, @0xabdulkadir! Glad that you eventually made it.
As a general advice, please ensure you create and check out a new branch (see contribution guideline, https://gist.github.com/ZakGriffith/69d1eb8baebddd7d370b87a65a7e3ec0), so that you adhere to the guidelines, which is important to contribute to open source projects.
Below you'll find some little comments.
| @@ -0,0 +1,55 @@ | |||
| import React from "react"; | |||
There was a problem hiding this comment.
You don't need to explicitly import React in Next.js anymore, starting from Next.js 12.2 and React 17 and above. With these versions, Next.js automatically imports React when needed, so you can safely omit import React from "react" at the top of your files.
| import { Address } from "~~/components/scaffold-eth"; | ||
| import { BlockieAvatar } from "~~/components/scaffold-eth"; | ||
|
|
||
| const PersonalPage = () => { |
There was a problem hiding this comment.
You might want to consider typing your page as NextPage since we are using TypeScript, as this ensures better integration and adds clarity for future maintainers by indicating that the component is a Next.js page.
Also you could consider it after your name since there are are many more personal pages.
| balance my studies with my hobbies. | ||
| </p> | ||
| <div className=" flex items-center gap-x-2 -my-3"> | ||
| <p>Address :</p>{" "} |
There was a problem hiding this comment.
It looks like the : is appearing on the next line (on smaller screen sizes). It would be great to have it in on line with Address.
And doublecheck if you need {" "}
| <div className=" flex justify-center items-center"> | ||
| <div> | ||
| <div className=" pt-24 lg:pt-[100px]"> | ||
| <div className="flex flex-col-reverse lg:flex-row items-center justify-center gap-x-[50px] md:mx-[550px]"> |
There was a problem hiding this comment.
Please double-check the mobile responsiveness, as it appears differently on smaller screens, as shown in the picture.
Description
Additional Information
Related Issues
Your ENS/address: 0x6d3321b4637D8451740Cf400848602f838F7A594