Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust batch table (removed github links, upcoming batch), added next starting to batch banner #61

Merged
merged 4 commits into from
Jan 3, 2025

Conversation

phipsae
Copy link
Contributor

@phipsae phipsae commented Dec 20, 2024

Description

New batch participants can easily access previous batch repositories and copy code from them. Even before the batch starts, they see what how the batch program looks like, which reduces the element of surprise. For this reason, I’d like to remove the GitHub links from the table. (I know the repositories aren’t too difficult to find otherwise, but it makes it less obvious).

I also removed the upcoming batch from the table and integrated the start date into the banner above.

Let me know if these changes work for you!

Screenshot 2024-12-20 at 11 29 02

Copy link

vercel bot commented Dec 20, 2024

@phipsae is attempting to deploy a commit to the BuidlGuidl Team on Vercel.

A member of the Team first needs to authorize it.

@carletex
Copy link
Contributor

New batch participants can easily access previous batch repositories and copy code from them. Even before the batch starts, they see what how the batch program looks like, which reduces the element of surprise. For this reason, I’d like to remove the GitHub links from the table. (I know the repositories aren’t too difficult to find otherwise, but it makes it less obvious).

I think this makes sense!

tagging @Pabl0cks so he can chime in too and review.

Thanks Philip!

Copy link

vercel bot commented Dec 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
buidlguidl-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 11:18pm

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements @phipsae !! I think it will be much better not showing the github repo to maintain the surprise factor.

Just added a few comments, mostly nitpicks/edge cases 🙌

@phipsae
Copy link
Contributor Author

phipsae commented Jan 3, 2025

Thanks @Pabl0cks for your review! Made the requested changes.

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the quick updates @phipsae.

Let's merge and hide those github links 🙌

@Pabl0cks Pabl0cks merged commit 73adff4 into BuidlGuidl:main Jan 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants