-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust batch table (removed github links, upcoming batch), added next starting to batch banner #61
Conversation
@phipsae is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
I think this makes sense! tagging @Pabl0cks so he can chime in too and review. Thanks Philip! |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvements @phipsae !! I think it will be much better not showing the github repo to maintain the surprise factor.
Just added a few comments, mostly nitpicks/edge cases 🙌
…es with status closed in table
Thanks @Pabl0cks for your review! Made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the quick updates @phipsae.
Let's merge and hide those github links 🙌
Description
New batch participants can easily access previous batch repositories and copy code from them. Even before the batch starts, they see what how the batch program looks like, which reduces the element of surprise. For this reason, I’d like to remove the GitHub links from the table. (I know the repositories aren’t too difficult to find otherwise, but it makes it less obvious).
I also removed the upcoming batch from the table and integrated the start date into the banner above.
Let me know if these changes work for you!