-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow admin to add note #108
Conversation
this fixes: Cannot use "undefined" as a Firestore value (found in field "approvedNote"). If you want to ignore undefined values, enable `ignoreUndefinedProperties`
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @technophile-04 !! Looks good to me, added a couple of nitpicks, but I think it could be merged like this 🙌
Things not handled / Kind of confused :
In my opinion both could be handled in the future if we feel the need, right now probably would just tell Admins to do rejections/approvals with notes 1 by 1. Maybe we realize there isn't the need to implement the batch with notes feature.
For the note update/deletion, we could start with a DM and a DB update when this happens, only afraid if we paste something unintended, but probably the chance is very low, and since we don't have notifications we probably would delete/update it before user realizes.
This looks great! Thanks Shiv and Pablo!
No notes for batches is fine I think.
This is fine too I think. For now, I think we have all we need. Thanks! |
Description
Demo :
Screen.Recording.2024-04-14.at.7.41.41.PM.mov
Things handled :
textarea
non-editable ?Things not handled / Kind of confused :
/admin
until user mark their grant submitted)