Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow admin to add note #108

Merged
merged 11 commits into from
Apr 15, 2024
Merged

Allow admin to add note #108

merged 11 commits into from
Apr 15, 2024

Conversation

technophile-04
Copy link
Member

Description

Demo :

Screen.Recording.2024-04-14.at.7.41.41.PM.mov

Things handled :

  1. Admin can add note while rejecting grant
  2. Admin can add note while approving grant
  3. User can see the note added by admin (tooltip)
  4. ^ Not sure if tooltip is best suited of this if admin plans to write long notes maybe we could show modal with HTML tag textarea non-editable ?

Things not handled / Kind of confused :

  1. How to handle adding of notes when doing batch operations (Umm maybe we can tell admin to fill note for each of grant we can create an extra modal similar to edit pencil icon and then admin clicks batch button)
  2. There is no way for admin to edit note once submitted (Where do we show this edit button ? Because Admin once mark the grant with approve / reject its gone from /admin until user mark their grant submitted)

Copy link

vercel bot commented Apr 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grants-bg ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 2:22pm

Copy link
Member

@Pabl0cks Pabl0cks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @technophile-04 !! Looks good to me, added a couple of nitpicks, but I think it could be merged like this 🙌

Things not handled / Kind of confused :

In my opinion both could be handled in the future if we feel the need, right now probably would just tell Admins to do rejections/approvals with notes 1 by 1. Maybe we realize there isn't the need to implement the batch with notes feature.

For the note update/deletion, we could start with a DM and a DB update when this happens, only afraid if we paste something unintended, but probably the chance is very low, and since we don't have notifications we probably would delete/update it before user realizes.

@carletex
Copy link
Contributor

This looks great! Thanks Shiv and Pablo!

How to handle adding of notes when doing batch operations (Umm maybe we can tell admin to fill note for each of grant we can create an extra modal similar to edit pencil icon and then admin clicks batch button)

No notes for batches is fine I think.

There is no way for admin to edit note once submitted (Where do we show this edit button ? Because Admin once mark the grant with approve / reject its gone from /admin until user mark their grant submitted)

This is fine too I think.

For now, I think we have all we need.

Thanks!

@carletex carletex merged commit fe86562 into main Apr 15, 2024
3 checks passed
@carletex carletex deleted the issue-100 branch April 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants