Match r4 impact metric calculation #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@escottalexander is attempting to deploy a commit to the BuidlGuidl Team on Vercel. A member of the Team first needs to authorize it. |
escottalexander
commented
Aug 26, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@escottalexander this looks good to me. The only issue I can think of is one we discussed a little while back, that metrics with higher units (like gas fees spent vs users onboarded), will have a greater effect on a project's impact index. Not sure how much of an issue this actuallt is, but I wanted to bring it up. |
|
In some discussion on Telegram we discovered the way we are currently doing this is better than what is proposed in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #116
Additional context from TG:
@websurferdoteth Re:
I am finally getting into this and I am thinking it is more appropriate for it to be this:
Otherwise we are returning the projects share of the impact for that day instead of just the raw impact (adjusted by the weights). When viewing an individual project, I don't think it matters as compared to other projects as much as comparing to its own past performance. Am I missing something? I am putting a PR together if you want to see my line of thinking in detail.