Simulatior enhancement

[ravirnjn88]

Added title and status bar to the simulator.
Snapshot : https://www.dropbox.com/s/j2va2xiftyx0v0f/TeplateSimulator.jpg?dl=0

[martinrotter]

The statusbar is perfectly fine, but title bar cannot be accepted. You used fixed images as titlebars, with this approach anyone who will write new template would have to create new image for titlebar, which is not acceptable.

You can use widget approach for titlebar. You simply add one more composite widget (two labels placed next to each other horizontally) to simulator window, place and size it appropriately, and displaying template simulation content below it.

The statusbar is perfect, I would code it almost exactly the way you did it. Just try to think more about titlebars. If you feel you cannot do widget-like approach, then separate those two features and propose pull request only with statusbar. :)

[croozeus]

I have the same views about the title bar. Let's have title bar as a separate widget as @martinrotter suggested and not as images.

[ravirnjn88]

If we use a separate widget approach then still we have to place the game icon in one label. So instead of using the icon.png file why not use the full titlebar image.png file.

[martinrotter]

Because template developers would have to design titlebars in exactly same ways. This is not acceptable prerequisite. It could be expected that template developer creates icon for template, but we cannot ask them to create unified titlebars. This is just nonsence, even if it is quite easy to implement this cleanly.

[ravirnjn88]

Got it..Thanks

[ravirnjn88]

@martinrotter Changed to separate widget approach as suggested by you. Please review the PR

[ravirnjn88]

Sorry for the late reply..travelling for the last one day..:)
I think we should not clutter the formsimulator class with titlebar code. Title bar was the part of game simulation and it should be included in the particular game simulation class.

[martinrotter]

Title bar is "shared" across all templates and it has the same exact looking for all templates. The only thing that changes is icon and the title text. All this attributes make me think for 100% that title bar code should be coded just once, not separately in each template.