Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Text to speech api #55

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ravirnjn88
Copy link
Contributor

Previous api of http://mary.dfki.de:59125 is not working. Change it to free api provided by http://tts-api.com (Issue #53 )

@ravirnjn88 ravirnjn88 changed the title Change the Text to speech api (Issue #53) Change the Text to speech api Mar 7, 2015
@martinrotter
Copy link
Contributor

Wow, nice job.

@@ -35,7 +35,9 @@
#include <QDir>
#include <QFile>
#include <QTextStream>

#include <QMediaPlayer>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, solve those #includes correctly. QMediaPlayer class is only available in Qt5. You commented out QSound usages, therefore QSound #ïnclude is not needed anymore. You could for example replace line 43 with line 38.

@ravirnjn88
Copy link
Contributor Author

I have checked the toolkit with Qt4, mp3 files were playing correctly.

@martinrotter
Copy link
Contributor

@ravirnjn88 OK, try this. Compile toolkit (in release mode with qt4) as you usually do. Then run "make install". Then go to "make install" output folder and run toolkit via the exe file. Then try if mp3 is running correctly.

Once you confirm it does, I will merge.

@martinrotter
Copy link
Contributor

  • There is memory leak. You create "new" instance of QMediaPlayer and do not destruct it after play is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants