Updated for compatibility with new TypeInfo-based Reflection API #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated for compatibility with new TypeInfo Reflection API, used in new .NET environments like Windows Phone 8.1 and Apps for Windows Store and their respective PCL profiles.
| var clonedFieldValue = InternalCopy(originalFieldValue, visited); | ||
| propertyInfo.SetValue(cloneObject, clonedFieldValue); | ||
| } | ||
| } |
There was a problem hiding this comment.
Why implement CopyProperties? Properties are just setter and getter functions with underlying fields in a different syntax. Those underlying fields should already be copied in the CopyFields() method.
There was a problem hiding this comment.
This was actually a oversight on my part. I have corrected this in my latest commit.
CopyProperties method has been removed because underlying property values are copied by the CopyField methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated for compatibility with new TypeInfo Reflection API, used in new
.NET environments like Windows Phone 8.1 , Apps for Windows Store and
their respective PCL profiles.