Skip to content

Commit

Permalink
also strip '--mkfs-time 0'
Browse files Browse the repository at this point in the history
Apparently appimagetool passes '--mkfs-time 0' to `mksquashfs`. It does this to make builds reproducible, but we set SOURCE_DATE_EPOCH for this purpose. If *both* are passed, then `mksquashfs`, exits with an error.

To be consistent, this commit just strips the `--mkfs-time 0` option

 * #78 (comment)
 * AppImage/AppImageKit#1202
  • Loading branch information
maltfield committed Mar 31, 2024
1 parent 1902e3a commit b12ebf6
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions build/linux/buildAppImage.sh
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,7 @@ export SOURCE_DATE_EPOCH="${SOURCE_DATE_EPOCH}"
# the new version of mksquashfs no longer supports the '-mkfs-fixed-time'
# argument, so we remove it
args=\$(echo "\$@" | sed -e 's/-mkfs-fixed-time 0//')
args=\$(echo "\$@" | sed -e 's/-mkfs-time 0//')
$(which mksquashfs) \$args
EOF

Expand Down

0 comments on commit b12ebf6

Please sign in to comment.