Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update #6

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

update #6

wants to merge 12 commits into from

Conversation

NJannasch
Copy link
Member

No description provided.

Copy link

@prisma-cloud-devsecops prisma-cloud-devsecops bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prisma Cloud has found errors in this PR ⬇️

Dockerfile Outdated
@@ -1,2 +1,2 @@
FROM simonpanw/spring4shell-vulnerable-tomcat:latest
FROM ubuntu:latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Healthcheck instructions have not been added to container images
    Resource: /Dockerfile. | Checkov ID: CKV_DOCKER_2

Description

We recommend that you add the HEALTHCHECK instruction to your Docker container images to ensure that health checks are executed against running containers.
An important security control is that of availability.
Adding the HEALTHCHECK instruction to your container image ensures that the Docker engine periodically checks the running container instances against that instruction to ensure that containers are still operational.
Based on the results of the health check, the Docker engine could terminate containers which are not responding correctly, and instantiate new ones.

Dockerfile Outdated
@@ -2 +1,2 @@
FROM ubuntu:latest

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOW  Base image uses a latest version tag
    Resource: /Dockerfile.FROM | Checkov ID: CKV_DOCKER_7

Description

When possible, it is recommended to pin the version for the base image in your Dockerfiles.
There are a number of potential issues that may be caused when using the latest tag.
Since latest is the default tag when a tag is not specified, it does not automatically refer to the latest version of the image.
This can lead to the use of outdated images and in the case of production deployments, using a dynamic version can cause unexpected behavior and difficulty in determining which version is being currently used.
It is best practice to be specific as possible about what is running to make operations predictable and reliable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant