-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update #6
base: main
Are you sure you want to change the base?
update #6
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prisma Cloud has found errors in this PR ⬇️
Dockerfile
Outdated
@@ -1,2 +1,2 @@ | |||
FROM simonpanw/spring4shell-vulnerable-tomcat:latest | |||
FROM ubuntu:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Healthcheck instructions have not been added to container images
Resource: /Dockerfile. | Checkov ID: CKV_DOCKER_2
Description
We recommend that you add the HEALTHCHECK instruction to your Docker container images to ensure that health checks are executed against running containers.
An important security control is that of availability.
Adding the HEALTHCHECK instruction to your container image ensures that the Docker engine periodically checks the running container instances against that instruction to ensure that containers are still operational.
Based on the results of the health check, the Docker engine could terminate containers which are not responding correctly, and instantiate new ones.
Dockerfile
Outdated
@@ -2 +1,2 @@ | |||
FROM ubuntu:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Base image uses a latest version tag
Resource: /Dockerfile.FROM | Checkov ID: CKV_DOCKER_7
Description
When possible, it is recommended to pin the version for the base image in your Dockerfiles.
There are a number of potential issues that may be caused when using the latest
tag.
Since latest
is the default tag when a tag is not specified, it does not automatically refer to the latest version of the image.
This can lead to the use of outdated images and in the case of production deployments, using a dynamic version can cause unexpected behavior and difficulty in determining which version is being currently used.
It is best practice to be specific as possible about what is running to make operations predictable and reliable
No description provided.